lkml.org 
[lkml]   [2013]   [Jan]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/5] kprobes: constify check_kprobe_address_safe and friends
(2013/01/25 13:09), Sasha Levin wrote:
> As to arch_check_optimized_kprobe() and check_kprobe_address_safe(), this
> is simply way too confusing. It doesn't make sense that a function named
> check_[...]() would modify any of it's parameters.
>
> For example, that entire block within KPROBES_CAN_USE_FTRACE should be split
> out and go into update_kprobe_for_ftrace() or something similar.
>
> If that makes sense, I can send a patch to split out all the parts that
> modify anything in those two functions out of them.

I see, that makes sense :-)

Thank you,

--
Masami HIRAMATSU
IT Management Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com




\
 
 \ /
  Last update: 2013-01-29 13:21    [W:0.051 / U:37.000 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site