Messages in this thread | | | Date | Tue, 29 Jan 2013 11:49:58 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH 2/2] perf: Make -lnuma optional |
| |
On Tue, Jan 29, 2013 at 11:48:12AM +0100, Borislav Petkov wrote: > From: Borislav Petkov <bp@suse.de> > > a0c17eadf3bf9 ("perf: Add 'perf bench numa mem' NUMA performance > measurement suite") added -lnuma to the EXTLIBS but we use those when > checking for other libraries like libelf, libunwind, etc and the checks > failed even when the dev libraries are installed on the system: > > CHK libelf > /usr/bin/ld: cannot find -lnuma > collect2: error: ld returned 1 exit status > CHK glibc > Makefile:552: No libelf found, disables 'probe' tool, please install elfutils-libelf-devel/libelf-dev > CHK libunwind > /usr/bin/ld: cannot find -lnuma > collect2: error: ld returned 1 exit status > Makefile:586: No libunwind found, disabling post unwind support. Please install libunwind-dev[el] >= 0.99 > ... > > So, add glue to detect the presence of -lnuma and build perf bench numa > only then.
While at it, I noticed another annoyance: if FLEX and BISON are needed unconditionally for the build, this needs to be checked at the beginning of the makefile and make shouldn't fail in-between. Oh well, I'll let someone beat me to it with a fix since I'm lazy :).
-- Regards/Gruss, Boris.
Sent from a fat crate under my desk. Formatting is fine. --
| |