Messages in this thread | | | Date | Mon, 28 Jan 2013 16:43:56 +0900 | Subject | Re: [PATCH v5 7/8] fat (exportfs): rebuild directory-inode if fat_dget() fails | From | Namjae Jeon <> |
| |
2013/1/26, OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>: > Namjae Jeon <linkinjeon@gmail.com> writes: > >> 2013/1/20, OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>: >>> Namjae Jeon <linkinjeon@gmail.com> writes: >>> >>>> We rewrite patch as your suggestion using dummy inode. Would please >>>> you review below patch code ? >>> >>> Looks like good as initial. Clean and shorter. >>> >>> Next is, we have to think about race. I.e. if real inode was made, what >>> happens? Is there no race? >> Hi OGAWA. >> >> Although checking several routines to check hang case you said, I >> didn't find anything. >> And There is no any race on test result also. Am I missing something ? >> Let me know your opinion. > > Hm, it's read-only. So, there may not be race for now, I'm sure there is > race on write path though. Yes, right. We checked/tested on read-only. Maybe have you found race with rename and unlink ? If yes, I think we can fix this issue with lock like this.
+ mutex_lock(&MSDOS_SB(sb)->s_lock); parent_inode = fat_rebuild_parent(sb, parent_logstart); + mutex_unlock(&MSDOS_SB(sb)->s_lock);
Let me know your opinion. Thanks. > > Thanks. > -- > OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> >
| |