lkml.org 
[lkml]   [2013]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v7 3/4] block: implement runtime pm strategy
On Mon, 28 Jan 2013, Aaron Lu wrote:

> On Sat, Jan 19, 2013 at 01:11:45PM -0500, Alan Stern wrote:
> > On Sat, 19 Jan 2013, Aaron Lu wrote:
> > > Considering ODD's use case, I was thinking of moving the
> > > blk_pm_runtime_init call to sd.c, as sr will not use request based auto
> > > suspend. Probably right before we decrease usage count for the device in
> > > sd_probe_async. What do you think?
> >
> > That makes sense. But then you should review the changes in scsi_pm.c
> > to make sure they will work okay for devices that aren't using
> > block-layer runtime PM.
>
> Now that we have two different runtime PM schemes for scsi device, and
> I think there are two ways to make them work:
>
> 1 Do it all in scsi_pm.c. In bus' runtime PM callback, check if this
> device is using block layer runtime PM API, and act accordingly;
> 2 Do it in indivisual drivers' runtime PM callback. Bus' runtime PM
> callbacks just call pm_generic_runtime_xxx, and each driver's runtime
> PM callback will need to do what is appropriate for them.
>
> Personally I want to go with option 1, but I would like to hear your
> opinion :-)

I don't think it matters very much. Option 1 is okay with me. James
might have a stronger feeling one way or the other.

Alan Stern



\
 
 \ /
  Last update: 2013-01-28 16:42    [W:0.078 / U:0.820 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site