lkml.org 
[lkml]   [2013]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 2/4] USB: dwc3: Adjust runtime pm the dwc3 driver to allow runtime suspend
    Date
    The current code in the dwc3 probe effectively disables runtime pm
    from ever working because it calls a get() that was never put() until
    device removal. Change the runtime pm code to match the standard
    formula and allow runtime pm to function.

    Note that this doesn't enable full runtime pm on the DWC3 device in
    that the port isn't put into a lower power mode when not used.
    However it does allow users of dwc3 (like dwc3-exynos) to do some
    amount of runtime power management.

    Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
    Signed-off-by: Doug Anderson <dianders@chromium.org>
    ---
    drivers/usb/dwc3/core.c | 4 +++-
    1 files changed, 3 insertions(+), 1 deletions(-)

    diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
    index 3a4004a..59c2494 100644
    --- a/drivers/usb/dwc3/core.c
    +++ b/drivers/usb/dwc3/core.c
    @@ -453,6 +453,7 @@ static int dwc3_probe(struct platform_device *pdev)
    if (of_get_property(node, "tx-fifo-resize", NULL))
    dwc->needs_fifo_resize = true;

    + pm_runtime_set_active(dev);
    pm_runtime_enable(dev);
    pm_runtime_get_sync(dev);
    pm_runtime_forbid(dev);
    @@ -517,6 +518,7 @@ static int dwc3_probe(struct platform_device *pdev)
    goto err2;
    }

    + pm_runtime_put(dev);
    pm_runtime_allow(dev);

    return 0;
    @@ -543,6 +545,7 @@ err1:

    err0:
    dwc3_free_event_buffers(dwc);
    + pm_runtime_disable(&pdev->dev);

    return ret;
    }
    @@ -554,7 +557,6 @@ static int dwc3_remove(struct platform_device *pdev)

    res = platform_get_resource(pdev, IORESOURCE_MEM, 0);

    - pm_runtime_put(&pdev->dev);
    pm_runtime_disable(&pdev->dev);

    dwc3_debugfs_exit(dwc);
    --
    1.7.6.5


    \
     
     \ /
      Last update: 2013-01-28 13:21    [W:4.603 / U:0.988 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site