lkml.org 
[lkml]   [2013]   [Jan]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 04/12] perf, x86: Support the TSX intx/intx_cp qualifiers v2

* Andi Kleen <andi@firstfloor.org> wrote:

> On Sat, Jan 26, 2013 at 12:54:02PM +0100, Ingo Molnar wrote:
> >
> > * Andi Kleen <andi@firstfloor.org> wrote:
> >
> > > From: Andi Kleen <ak@linux.intel.com>
> > >
> > > Implement the TSX transaction and checkpointed transaction
> > > qualifiers for Haswell. This allows e.g. to profile the number
> > > of cycles in transactions.
> >
> > The changelog should explain why this is a basic feature
> > that is a must-have to have basic perf support. (i.e.
> > default 'perf record', 'perf report', 'perf stat' and 'perf
> > top' works and is meaningful.)
>
> The patch is not needed for primitive cycle sampling only.

So please re-send a truly minimal hw-enabling series first, as
requested - a minimal series that enables most of the everyday
usecases.

> These qualifiers are a fundamental feature for any TSX tuning.

Any new, Haswell-specific profiling features should obviously be
in a second (or third) series of patches.

Thanks,

Ingo


\
 
 \ /
  Last update: 2013-01-27 14:41    [W:0.067 / U:22.972 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site