Messages in this thread Patch in this message | | | From | Jiri Olsa <> | Subject | [PATCH 6/9] perf tools: Favor 'p' modifier before 'precise' term properly | Date | Sat, 26 Jan 2013 18:27:52 +0100 |
| |
The 'p' event modifier is stronger than setting precise_ip using the 'precise' term, like:
'cpu/cycles,precise/' - precise_ip = sysfs precise value 'cpu/cycles,precise/p' - precise_ip = 1
There's currently bug if the event modifier without 'p' is specified the precise_ip is set to zero, like:
'cpu/cycles,precise/u' - precise_ip = 0
This patch makes sure that the precise_ip value is overwritten only if any 'p' event modifier is specified, like:
'cpu/cycles,precise/u' - precise_ip = sysfs precise value
Signed-off-by: Jiri Olsa <jolsa@redhat.com> Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com> Cc: Frederic Weisbecker <fweisbec@gmail.com> Cc: Ingo Molnar <mingo@elte.hu> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Paul Mackerras <paulus@samba.org> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Cc: Arnaldo Carvalho de Melo <acme@redhat.com> Cc: Andi Kleen <ak@linux.intel.com> Cc: David Ahern <dsahern@gmail.com> --- tools/perf/util/parse-events.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c index a92c403..83362f2 100644 --- a/tools/perf/util/parse-events.c +++ b/tools/perf/util/parse-events.c @@ -818,7 +818,14 @@ int parse_events__modifier_event(struct list_head *list, char *str, bool add) evsel->attr.exclude_user = mod.eu; evsel->attr.exclude_kernel = mod.ek; evsel->attr.exclude_hv = mod.eh; - evsel->attr.precise_ip = mod.precise; + + /* + * Change precise only if it's defined, so we don't + * overwrite 'precise' term if there's no 'p' modifier. + */ + if (mod.precise) + evsel->attr.precise_ip = mod.precise; + evsel->attr.exclude_host = mod.eH; evsel->attr.exclude_guest = mod.eG; evsel->exclude_GH = mod.exclude_GH; -- 1.7.11.7
| |