lkml.org 
[lkml]   [2013]   [Jan]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 12/14] inotify: don't use idr_remove_all()
    Date
    idr_destroy() can destroy idr by itself and idr_remove_all() is being
    deprecated. Drop its usage.

    Signed-off-by: Tejun Heo <tj@kernel.org>
    Cc: John McCutchan <john@johnmccutchan.com>
    Cc: Robert Love <rlove@rlove.org>
    Cc: Eric Paris <eparis@parisplace.org>
    ---
    This patch depends on an earlier idr patch and given the trivial
    nature of the patch, I think it would be best to route these together
    through -mm. Please holler if there's any objection.

    Thanks.

    fs/notify/inotify/inotify_fsnotify.c | 1 -
    1 file changed, 1 deletion(-)

    diff --git a/fs/notify/inotify/inotify_fsnotify.c b/fs/notify/inotify/inotify_fsnotify.c
    index 871569c..4216308 100644
    --- a/fs/notify/inotify/inotify_fsnotify.c
    +++ b/fs/notify/inotify/inotify_fsnotify.c
    @@ -197,7 +197,6 @@ static void inotify_free_group_priv(struct fsnotify_group *group)
    {
    /* ideally the idr is empty and we won't hit the BUG in the callback */
    idr_for_each(&group->inotify_data.idr, idr_callback, group);
    - idr_remove_all(&group->inotify_data.idr);
    idr_destroy(&group->inotify_data.idr);
    atomic_dec(&group->inotify_data.user->inotify_devs);
    free_uid(group->inotify_data.user);
    --
    1.8.1


    \
     
     \ /
      Last update: 2013-01-26 06:41    [W:4.129 / U:0.212 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site