lkml.org 
[lkml]   [2013]   [Jan]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 3/3] timekeeping: Add CONFIG_HAS_PERSISTENT_CLOCK option
On 01/22/2013 11:49 AM, John Stultz wrote:
> On 01/22/2013 11:44 AM, Jason Gunthorpe wrote:
>> On Tue, Jan 15, 2013 at 11:50:18AM -0800, John Stultz wrote:
>>> On 01/15/2013 08:09 AM, Feng Tang wrote:
>>>> Make the persistent clock check a kernel config option, so that some
>>>> platform can explicitely select it, also make CONFIG_RTC_HCTOSYS
>>>> depends
>>>> on its non-existence, which could prevent the persistent clock and RTC
>>>> code from doing similar thing twice during system's
>>>> init/suspend/resume
>>>> phases.
>>>>
>>>> If the CONFIG_HAS_PERSISTENT_CLOCK=n, then no change happens for
>>>> kernel
>>>> which still does the persistent clock check in timekeeping_init().
>>>>
>>>> Cc: Thomas Gleixner <tglx@linutronix.de>
>>>> Suggested-by: John Stultz <john.stultz@linaro.org>
>>>> Signed-off-by: Feng Tang <feng.tang@intel.com>
>>> Applied. I also added a dependency for Jason's CONFIG_RTC_SYSTOHC.
>> Sort of an ugly config name, since I gather ARM should always set this
>> to 'n'...
>>
>> CONFIG_USE_ONLY_PERSISTENT_CLOCK ?
> (Sigh. I got this seemingly microseconds after I sent the pull request :)
>
> So yea, fair point, there could be some confusion. But
> ONLY_PERSISTENT_CLOCK isn't quite right either, more like
> CONFIG_HAS_PERSISTENT_CLOCK_ALWAYS or something.
>

Decided upon CONFIG_ALWAYS_USE_PERSISTENT_CLOCK which I think is clear
enough.

Let me know if you object or have a better idea.

thanks
-john



\
 
 \ /
  Last update: 2013-01-26 02:41    [W:0.048 / U:4.540 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site