lkml.org 
[lkml]   [2013]   [Jan]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [patch v1 2/5] regulator: da9055 change irq state to default
From
Date
On Thu, 2013-01-24 at 00:03 +0800, Mark Brown wrote:
> On Mon, Jan 21, 2013 at 02:05:12PM +0530, Ashish Jangam wrote:
>
> > > What makes you say that there is a dependency here? It's really not at
> > > all obvious why a change to the primary IRQ signalling mechanism would
> > > affect the internal interrupts of the device.
>
> > Yes, functionally this dependency should not matter.However, if
> > mfd/primary irq state is low and its components are high then it shall
> > not look good. Therefore the term dependency was used, probably I should
> > have written it in a different manner.
>
> This logic doesn't follow terribly directly - looking at what you've
> posted it in fact seems that the trigger type is irrelevant in the
> function drivers?
Though it is functionally irrelevant but in the code setting the primary
irq to low and functional driver to high may confuse the code reader.
However I leave this decision to you.




\
 
 \ /
  Last update: 2013-01-25 10:01    [W:0.044 / U:9.316 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site