lkml.org 
[lkml]   [2013]   [Jan]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/4] ARM: OMAP2+: dpll: round rate to closest value
Hi

On Wed, 23 Jan 2013, Afzal Mohammed wrote:

> Currently round rate function would return proper rate iff requested
> rate exactly matches the PLL lockable rate. This causes set_rate to
> fail if exact rate could not be set. Instead round rate may return
> closest rate possible (less than the requested). And if any user is
> badly in need of exact rate, then return value of round rate could
> be used to decide whether to invoke set rate or not.
>
> Modify round rate so that it return closest possible rate.

This doesn't look like the right approach to me. For some PLLs, an exact
rate is desired.

We removed the rate tolerance code in commit
241d3a8dca239610d3d991bf58d4fe38c2d86fd5, but that was probably premature.
We've encountered several situations now where we could really use it,
like MPU CPUFreq. I'd suggest reverting
241d3a8dca239610d3d991bf58d4fe38c2d86fd5 or using a similar approach.


- Paul


\
 
 \ /
  Last update: 2013-01-25 10:01    [W:0.085 / U:3.968 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site