lkml.org 
[lkml]   [2013]   [Jan]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] firmware: Make user-mode helper optional
At Fri, 25 Jan 2013 11:12:03 +0800,
Ming Lei wrote:
>
> On Tue, Jan 22, 2013 at 7:51 PM, Takashi Iwai <tiwai@suse.de> wrote:
> > Since 3.7 kernel, the firmware loader can read the firmware files
> > directly, and the traditional user-mode helper is invoked only as a
> > fallback. This seems working pretty well, and the next step would be
> > to reduce the redundant user-mode helper stuff in future.
>
> The idea is good.
>
> >
> > This patch is a preparation for that, to make the user-mode helper
> > invocation optional via kconfig. Other than that, there is no
> > functional change here.
>
> In fact, your patch does much code refactoring work, which isn't
> strictly related with what you claimed in the commit log, at least
> it should be separated from introducing FW_LOADER_USER_HELPER.
>
> So could you split the patch into several parts and let one part do one thing
> so that we can review them a bit easily?

Fair enough. Will submit the revised patches soon.

>
> Also it is not good to introduce too many '#ifdef #endif', IMO.

Heh, that can be much worse :)


thanks,

Takashi


\
 
 \ /
  Last update: 2013-01-25 17:43    [W:0.039 / U:9.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site