lkml.org 
[lkml]   [2013]   [Jan]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[tip:perf/core] perf sort: Clean up sort__first_dimension setting
    Commit-ID:  6f38cf25a6af5b21da1d52a94d9f56f5af2a215b
    Gitweb: http://git.kernel.org/tip/6f38cf25a6af5b21da1d52a94d9f56f5af2a215b
    Author: Namhyung Kim <namhyung.kim@lge.com>
    AuthorDate: Thu, 27 Dec 2012 18:11:45 +0900
    Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
    CommitDate: Thu, 24 Jan 2013 16:40:25 -0300

    perf sort: Clean up sort__first_dimension setting

    It doesn't need to compare to every sort key names since the index
    already has the required information.

    Signed-off-by: Namhyung Kim <namhyung@kernel.org>
    Acked-by: Jiri Olsa <jolsa@redhat.com>
    Cc: David Ahern <dsahern@gmail.com>
    Cc: Ingo Molnar <mingo@kernel.org>
    Cc: Jiri Olsa <jolsa@redhat.com>
    Cc: Paul Mackerras <paulus@samba.org>
    Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
    Cc: Stephane Eranian <eranian@google.com>
    Link: http://lkml.kernel.org/r/1356599507-14226-9-git-send-email-namhyung@kernel.org
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    ---
    tools/perf/util/sort.c | 26 ++------------------------
    1 file changed, 2 insertions(+), 24 deletions(-)

    diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c
    index a36051b..39b1ab0 100644
    --- a/tools/perf/util/sort.c
    +++ b/tools/perf/util/sort.c
    @@ -526,30 +526,8 @@ int sort_dimension__add(const char *tok)
    if (sd->entry->se_collapse)
    sort__need_collapse = 1;

    - if (list_empty(&hist_entry__sort_list)) {
    - if (!strcmp(sd->name, "pid"))
    - sort__first_dimension = SORT_PID;
    - else if (!strcmp(sd->name, "comm"))
    - sort__first_dimension = SORT_COMM;
    - else if (!strcmp(sd->name, "dso"))
    - sort__first_dimension = SORT_DSO;
    - else if (!strcmp(sd->name, "symbol"))
    - sort__first_dimension = SORT_SYM;
    - else if (!strcmp(sd->name, "parent"))
    - sort__first_dimension = SORT_PARENT;
    - else if (!strcmp(sd->name, "cpu"))
    - sort__first_dimension = SORT_CPU;
    - else if (!strcmp(sd->name, "symbol_from"))
    - sort__first_dimension = SORT_SYM_FROM;
    - else if (!strcmp(sd->name, "symbol_to"))
    - sort__first_dimension = SORT_SYM_TO;
    - else if (!strcmp(sd->name, "dso_from"))
    - sort__first_dimension = SORT_DSO_FROM;
    - else if (!strcmp(sd->name, "dso_to"))
    - sort__first_dimension = SORT_DSO_TO;
    - else if (!strcmp(sd->name, "mispredict"))
    - sort__first_dimension = SORT_MISPREDICT;
    - }
    + if (list_empty(&hist_entry__sort_list))
    + sort__first_dimension = i;

    list_add_tail(&sd->entry->list, &hist_entry__sort_list);
    sd->taken = 1;

    \
     
     \ /
      Last update: 2013-01-25 15:44    [W:2.335 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site