[lkml]   [2013]   [Jan]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[tip:perf/core] perf kvm: Initialize file_name var to fix segfault
Commit-ID:  20914ce5b9e1ef4a35f1f09a2c9c8fb8eb1c4d86
Author: Arnaldo Carvalho de Melo <>
AuthorDate: Wed, 19 Dec 2012 10:59:29 -0300
Committer: Arnaldo Carvalho de Melo <>
CommitDate: Thu, 24 Jan 2013 16:40:13 -0300

perf kvm: Initialize file_name var to fix segfault

The 3786063 commit:

perf kvm: Rename perf_kvm to perf_kvm_stat

Moved the file_name from inside a local struct var that initialized some
of its members, thus zero initializing the not explicitely initialized
variables, one of which was 'file_name', to a standalone local variable,
but forgot to initialize it explicitely to NULL, so it then got some
undefined value, causing a segfault in strdup when it wasn't, by luck,

Fix it by explicitely initializing it to NULL.

Cc: David Ahern <>
Cc: Frederic Weisbecker <>
Cc: Jiri Olsa <>
Cc: Mike Galbraith <>
Cc: Namhyung Kim <>
Cc: Paul Mackerras <>
Cc: Peter Zijlstra <>
Cc: Stephane Eranian <>
Cc: Xiao Guangrong <>
Signed-off-by: Arnaldo Carvalho de Melo <>
tools/perf/builtin-kvm.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tools/perf/builtin-kvm.c b/tools/perf/builtin-kvm.c
index ca3f80e..37a769d 100644
--- a/tools/perf/builtin-kvm.c
+++ b/tools/perf/builtin-kvm.c
@@ -973,8 +973,7 @@ __cmd_buildid_list(const char *file_name, int argc, const char **argv)

int cmd_kvm(int argc, const char **argv, const char *prefix __maybe_unused)
- const char *file_name;
+ const char *file_name = NULL;
const struct option kvm_options[] = {
OPT_STRING('i', "input", &file_name, "file",
"Input file name"),

 \ /
  Last update: 2013-01-25 13:01    [W:0.033 / U:7.984 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site