lkml.org 
[lkml]   [2013]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH v1 3/8] usb: otg: palmas-usb: remove compiler warning
Date
commit 696c5c04 (USB: Palmas OTG Transceiver Driver) introduced empty
palmas_vbus_irq/palmas_id_irq with only *palmas_usb* declaration.
Removed these unnecessary functions.

Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
---
drivers/usb/otg/palmas-usb.c | 38 --------------------------------------
1 file changed, 38 deletions(-)

diff --git a/drivers/usb/otg/palmas-usb.c b/drivers/usb/otg/palmas-usb.c
index f063350..be9d81c 100644
--- a/drivers/usb/otg/palmas-usb.c
+++ b/drivers/usb/otg/palmas-usb.c
@@ -103,15 +103,6 @@ static ssize_t palmas_usb_vbus_show(struct device *dev,
}
static DEVICE_ATTR(vbus, 0444, palmas_usb_vbus_show, NULL);

-static irqreturn_t palmas_vbus_irq(int irq, void *_palmas_usb)
-{
- struct palmas_usb *palmas_usb = _palmas_usb;
-
- /* TODO: Do we need to do any work here? */
-
- return IRQ_HANDLED;
-}
-
static irqreturn_t palmas_vbus_wakeup_irq(int irq, void *_palmas_usb)
{
struct palmas_usb *palmas_usb = _palmas_usb;
@@ -138,15 +129,6 @@ static irqreturn_t palmas_vbus_wakeup_irq(int irq, void *_palmas_usb)
return IRQ_HANDLED;
}

-static irqreturn_t palmas_id_irq(int irq, void *_palmas_usb)
-{
- struct palmas_usb *palmas_usb = _palmas_usb;
-
- /* TODO: Do we need to do any work here? */
-
- return IRQ_HANDLED;
-}
-
static irqreturn_t palmas_id_wakeup_irq(int irq, void *_palmas_usb)
{
int status = 0;
@@ -329,16 +311,6 @@ static int palmas_usb_probe(struct platform_device *pdev)

INIT_WORK(&palmas_usb->set_vbus_work, palmas_set_vbus_work);

- status = devm_request_threaded_irq(palmas_usb->dev, palmas_usb->irq1,
- NULL, palmas_id_irq,
- IRQF_TRIGGER_FALLING | IRQF_TRIGGER_RISING,
- "palmas_usb", palmas_usb);
- if (status < 0) {
- dev_err(&pdev->dev, "can't get IRQ %d, err %d\n",
- palmas_usb->irq1, status);
- goto fail_irq;
- }
-
status = devm_request_threaded_irq(palmas_usb->dev, palmas_usb->irq2,
NULL, palmas_id_wakeup_irq,
IRQF_TRIGGER_FALLING | IRQF_TRIGGER_RISING,
@@ -349,16 +321,6 @@ static int palmas_usb_probe(struct platform_device *pdev)
goto fail_irq;
}

- status = devm_request_threaded_irq(palmas_usb->dev, palmas_usb->irq3,
- NULL, palmas_vbus_irq,
- IRQF_TRIGGER_FALLING | IRQF_TRIGGER_RISING,
- "palmas_usb", palmas_usb);
- if (status < 0) {
- dev_err(&pdev->dev, "can't get IRQ %d, err %d\n",
- palmas_usb->irq3, status);
- goto fail_irq;
- }
-
status = devm_request_threaded_irq(palmas_usb->dev, palmas_usb->irq4,
NULL, palmas_vbus_wakeup_irq,
IRQF_TRIGGER_FALLING | IRQF_TRIGGER_RISING,
--
1.7.9.5


\
 
 \ /
  Last update: 2013-01-25 04:41    [W:2.181 / U:0.796 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site