lkml.org 
[lkml]   [2013]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] staging/comedi: Move comedi_pci_auto_unconfig to drivers.c
Date
Am Donnerstag, 24. Januar 2013, 11:02:35 schrieb Ian Abbott:
> On 2013-01-22 23:03, Peter Huewe wrote:
> > Since comedi_pci_auto_unconfig cannot be inlined anymore after
> >
> > staging/comedi: Use comedi_pci_auto_unconfig directly for
> > pci_driver.remove
> >
> > is applied, it makes sense to move it drivers.c
> >
> > Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
> > ---
> >

> Embarassingly (for me) I submitted a patch to do the exact opposite
> previously, but I've no problem doing it this way if it saves some code.

Hi Ian,
;)

If you think it's cleaner the way it is currently we can leave it like that.
Especially if you think some driver might actually do something in the remove
function (in the future).

However if we could also find a way to remove all the probe function stuff as
well we should remove it.
Most (comedi pci) drivers simply call comedi_pci_auto_config and not much more
- but I'm currently not sure how to do this ;)

Thanks,
PeterH



\
 
 \ /
  Last update: 2013-01-25 03:41    [W:0.070 / U:6.320 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site