lkml.org 
[lkml]   [2013]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/4] async: replace list of active domains with global list of pending items
Hi,

On Fri, Jan 18, 2013 at 04:41:00PM -0800, Tejun Heo wrote:
> @@ -125,9 +134,8 @@ static void async_run_entry_fn(struct work_struct *work)
>
> /* 2) remove self from the pending queues */
> spin_lock_irqsave(&async_lock, flags);
> - list_del(&entry->list);
> - if (domain->registered && list_empty(&domain->pending))
> - list_del_init(&domain->node);
> + list_del_init(&entry->domain_list);
> + list_del_init(&entry->global_list);

this unconditionally unlinks the global_list entry, however...

>
> /* 3) free the entry */
> kfree(entry);
> @@ -168,10 +176,14 @@ static async_cookie_t __async_schedule(async_func_ptr *ptr, void *data, struct a
> entry->domain = domain;
>
> spin_lock_irqsave(&async_lock, flags);
> +
> + /* allocate cookie and queue */
> newcookie = entry->cookie = next_cookie++;
> - if (domain->registered && list_empty(&domain->pending))
> - list_add_tail(&domain->node, &async_domains);
> - list_add_tail(&entry->list, &domain->pending);
> +
> + list_add_tail(&entry->domain_list, &domain->pending);
> + if (domain->registered)
> + list_add_tail(&entry->global_list, &async_global_pending);

if (!domain->registered) then entry->global_list will have NULL pointers
from the kzalloc, so the list_del_init above will crash.

Should it have this?
+ else
+ INIT_LIST_HEAD(&entry->global_list)

Cheers
James


\
 
 \ /
  Last update: 2013-01-25 01:41    [W:0.319 / U:0.384 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site