Messages in this thread | | | Date | Thu, 24 Jan 2013 11:44:40 -0700 | From | David Ahern <> | Subject | Re: [PATCH 0/4] perf tools: some 'perf script' fixes |
| |
On 1/24/13 11:27 AM, Arnaldo Carvalho de Melo wrote: > Em Fri, Jan 18, 2013 at 01:51:24PM -0600, Tom Zanussi escreveu: >> This patchset fixes various problems I hit while doing a run-through >> of the existing 'perf script' scripts. >> >> Also, sometimes when running rwtop I get a 'failed to read event >> header' error, which this patch fixes: >> >> https://lkml.org/lkml/2012/9/14/401 >> >> Not sure if that was meant to get picked up, but it fixed that >> particular problem here for me. > > David, can you please resubmit it with an explanation in the commit > message?
As part of other perf related activities I have noticed that readn is used in some places that we will want it to return immediately -- e.g., evsel.c. So, this might not be the proper fix for all use cases.
David
| |