Messages in this thread | | | Date | Thu, 24 Jan 2013 09:02:49 -0800 | From | gg <> | Subject | Re: [PATCH 2/2] regulator: tps65910: Fix using wrong dev argument for calling of regulator match |
| |
On 2013-01-23 20:45, Laxman Dewangan wrote: > On Thursday 24 January 2013 08:01 AM, Axel Lin wrote: >> The dev parameter is the device requesting the data. >> In this case it should be &pdev->dev rather than pdev->dev.parent. >> >> The dev parameter is used to call devm_kzalloc in >> of_get_regulator_init_data(), >> which means this fixes a memory leak because the memory is allocated >> every time >> probe() is called, thus it should be freed when this driver is >> unloaded. >> >> Signed-off-by: Axel Lin <axel.lin@ingics.com> >> --- > > Agree with the change. > Acked-by: Laxman Dewangan<ldewangan@nvidia.com>
Also agree.
Acked-by: Graeme Gregory <gg@slimlogic.co.uk>
| |