lkml.org 
[lkml]   [2013]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] regulator: tps65910: Fix using wrong dev argument for calling of regulator match
On 2013-01-23 20:45, Laxman Dewangan wrote:
> On Thursday 24 January 2013 08:01 AM, Axel Lin wrote:
>> The dev parameter is the device requesting the data.
>> In this case it should be &pdev->dev rather than pdev->dev.parent.
>>
>> The dev parameter is used to call devm_kzalloc in
>> of_get_regulator_init_data(),
>> which means this fixes a memory leak because the memory is allocated
>> every time
>> probe() is called, thus it should be freed when this driver is
>> unloaded.
>>
>> Signed-off-by: Axel Lin <axel.lin@ingics.com>
>> ---
>
> Agree with the change.
> Acked-by: Laxman Dewangan<ldewangan@nvidia.com>

Also agree.

Acked-by: Graeme Gregory <gg@slimlogic.co.uk>



\
 
 \ /
  Last update: 2013-01-24 19:01    [W:0.065 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site