Messages in this thread Patch in this message | | | From | Lord Glauber Costa of Sealand <> | Subject | [PATCH v6 01/12] don't call cpuacct_charge in stop_task.c | Date | Thu, 24 Jan 2013 19:17:31 +0400 |
| |
From: Glauber Costa <glommer@parallels.com>
Commit 8f618968 changed stop_task to do the same bookkeping as the other classes. However, the call to cpuacct_charge() doesn't affect the scheduler decisions at all, and doesn't need to be moved over.
Moreover, being a kthread, the migration thread won't belong to any cgroup anyway, rendering this call quite useless.
Signed-off-by: Glauber Costa <glommer@parallels.com> CC: Mike Galbraith <mgalbraith@suse.de> CC: Peter Zijlstra <a.p.zijlstra@chello.nl> CC: Thomas Gleixner <tglx@linutronix.de> --- kernel/sched/stop_task.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/kernel/sched/stop_task.c b/kernel/sched/stop_task.c index da5eb5b..fda1cbe 100644 --- a/kernel/sched/stop_task.c +++ b/kernel/sched/stop_task.c @@ -68,7 +68,6 @@ static void put_prev_task_stop(struct rq *rq, struct task_struct *prev) account_group_exec_runtime(curr, delta_exec); curr->se.exec_start = rq->clock_task; - cpuacct_charge(curr, delta_exec); } static void task_tick_stop(struct rq *rq, struct task_struct *curr, int queued) -- 1.8.1
| |