Messages in this thread | | | Date | Thu, 24 Jan 2013 10:34:20 -0500 | From | Josef Bacik <> | Subject | Re: [PATCH] btrfs: fix potential null pointer dereference bug |
| |
On Sat, Jan 19, 2013 at 08:27:45AM -0700, Cong Ding wrote: > The bug happens when rb_node == NULL. It causes variable node to be NULL and > then the NULL pointer is dereferenced this line: > BUG_ON((struct btrfs_root *)node->data != root); > > Based on my analysis, function tree_search should not return NULL to variable > rb_node in this case (otherwise here has to be something unknown thing wrong), > so I replace "if (rb_node)" with UG_ON(!rb_node). > > Signed-off-by: Cong Ding <dinggnu@gmail.com>
I don't want to add more BUG_ON()'s, just return an error.
Josef
| |