Messages in this thread | | | Date | Thu, 24 Jan 2013 11:16:23 +0530 | From | Vineet Gupta <> | Subject | Re: [PATCH v2 65/76] ARC: UAPI Disintegrate arch/arc/include/asm |
| |
On Wednesday 23 January 2013 06:20 PM, David Howells wrote: > Vineet Gupta <Vineet.Gupta1@synopsys.com> wrote: > >> I generated this patch using the scripts you provided. If these look OK to >> you, can you please ACK. > > You need to take a look at uapi/asm/setup.h. It's created as an empty file - > which will get discarded by patch. Do you actually need a UAPI instance of > that? > > David >
Given that setup.h is exported by include/uapi/asm-generic/Kbuild.asm (as part of userspace header ABI) there's no way we can avoid it's uapi sibling - even if empty. But to workaround patch discarding it, I will add a placeholder comment in generated setup.h (just like you did for arch/cris). Would that take care of it ?
BTW looking at metag port, it seems that <asm/setup.h> does #include <uapi/asm/setup.h>, but latter doesn't exist in the repository - is it generated for you James or is this same issue which David elucidated to above ?
-Vineet
| |