lkml.org 
[lkml]   [2013]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] CONFIG_PANIC_ON_OOPS should be shown if DEBUG_KERNEL

* Andrew Morton <akpm@linux-foundation.org> wrote:

> On Tue, 22 Jan 2013 14:21:03 -0500
> Kyle McMartin <kyle@redhat.com> wrote:
>
> > CONFIG_EXPERT is a bit silly a place for this, and hides it
> > unnecessarily. CONFIG_DEBUG_KERNEL makes much more sense.
> >
> > Signed-off-by: Kyle McMartin <kyle@redhat.com>
> >
> > --- a/lib/Kconfig.debug
> > +++ b/lib/Kconfig.debug
> > @@ -243,7 +243,7 @@ config BOOTPARAM_SOFTLOCKUP_PANIC_VALUE
> > default 1 if BOOTPARAM_SOFTLOCKUP_PANIC
> >
> > config PANIC_ON_OOPS
> > - bool "Panic on Oops" if EXPERT
> > + bool "Panic on Oops" if DEBUG_KERNEL
> > default n
> > help
> > Say Y here to enable the kernel to panic when it oopses. This
>
> hm, I'm not sure that it should depend on anything. Where's the benefit?

Agreed.

(The 'default n' is superfuous as well, while at it.)

Thanks,

Ingo


\
 
 \ /
  Last update: 2013-01-24 12:01    [W:0.049 / U:0.948 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site