lkml.org 
[lkml]   [2013]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 44/74] target: Release se_cmd when LUN lookup fails for TMR
    Date
    3.5.7.4 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Roland Dreier <roland@purestorage.com>

    commit 5a3b6fc0092c5f8dee7820064ee54d2631d48573 upstream.

    When transport_lookup_tmr_lun() fails and we return a task management
    response from target_complete_tmr_failure(), we need to call
    transport_cmd_check_stop_to_fabric() to release the last ref to the
    cmd after calling se_tfo->queue_tm_rsp(), or else we will never remove
    the failed TMR from the session command list (and we'll end up waiting
    forever when trying to tear down the session).

    (nab: Fix minor compile breakage)

    Signed-off-by: Roland Dreier <roland@purestorage.com>
    Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
    Signed-off-by: Herton Ronaldo Krzesinski <herton.krzesinski@canonical.com>
    ---
    drivers/target/target_core_transport.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c
    index d6c73e8..047f49a 100644
    --- a/drivers/target/target_core_transport.c
    +++ b/drivers/target/target_core_transport.c
    @@ -1614,6 +1614,8 @@ static void target_complete_tmr_failure(struct work_struct *work)

    se_cmd->se_tmr_req->response = TMR_LUN_DOES_NOT_EXIST;
    se_cmd->se_tfo->queue_tm_rsp(se_cmd);
    +
    + transport_cmd_check_stop_to_fabric(se_cmd);
    }

    /**
    --
    1.7.9.5


    \
     
     \ /
      Last update: 2013-01-24 05:21    [W:3.260 / U:0.236 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site