Messages in this thread | | | Subject | Re: [PATCH 3.8-rc4-nohz3] kvm: Add missing EXPORT_SYMBOL when CONFIG_KVM=m | From | Steven Rostedt <> | Date | Wed, 23 Jan 2013 10:04:47 -0500 |
| |
On Wed, 2013-01-23 at 15:02 +0100, Frederic Weisbecker wrote:
> diff --git a/kernel/context_tracking.c b/kernel/context_tracking.c > index bbb2c2c..a13b8a3 100644 > --- a/kernel/context_tracking.c > +++ b/kernel/context_tracking.c > @@ -111,14 +111,19 @@ void guest_enter(void) > else > __guest_enter(); > } > +EXPORT_SYMBOL_GPL(guest_enter); > > void guest_exit(void) > { > +#ifndef CONFIG_KVM > +i > +#endif
I don't like #ifdefs in .c files. They belong in headers. Could you convert this to be:
include/linux/context_tracking.h:
#ifdef CONFIG_KVM #define add_vi_i_typo() #else #define add_vi_i_typo() i #endif
and then in context_tracking.c:
void guest_exit(void) { add_vi_typo();
[...]
-- Steve
> if (vtime_accounting_enabled()) > vtime_guest_exit(current); > else > __guest_exit(); > } > +EXPORT_SYMBOL_GPL(guest_exit); > #endif
| |