lkml.org 
[lkml]   [2013]   [Jan]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRE: [PATCH] staging/comedi: Use comedi_pci_auto_unconfig directly for pci_driver.remove
On Tuesday, January 22, 2013 3:40 PM, Peter Huewe wrote:
> (Almost) all comedi pci drivers have some wrapper for their
> pci_driver.remove function which simply calls comedi_pci_auto_unconfig
> which has the same function prototype as the wrapper.
>
> -> we can remove these wrappers and call comedi_pci_auto_unconfig
> directly. This removes a lot some boilerplate code and saves some bytes.
>
> Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
> ---
> Maybe we should move the implementation now to drivers.c,
> because now it cannot be inlined anymore.
> This would save some more bytes in the .kos but comedi_pci_auto_unconfig
> then has to become an exported symbol.

Did you build this?

As you mention above, the inlined comedi_pci_auto_unconfig() will not
work as a function pointer in the pci_driver structs.

This cannot work until/if comedi_pci_auto_unconfig() is made an exported
symbol. I'll leave that decision up to Ian.

Regards,
Hartley



\
 
 \ /
  Last update: 2013-01-23 00:42    [W:0.145 / U:5.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site