lkml.org 
[lkml]   [2013]   [Jan]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] f2fs: use _safe() version of list_for_each
On Sun, Jan 20, 2013 at 06:02:58PM +0300, Dan Carpenter wrote:
> This is calling list_del() inside a loop which is a problem when we try
> move to the next item on the list. I've converted it to use the _safe
> version. And also, as a cleanup, I've converted it to use
> list_for_each_entry instead of list_for_each.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> Static analysis stuff. Untested. Please review carefully.

Makes sense to me.

Reviewed-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

>
> diff --git a/fs/f2fs/recovery.c b/fs/f2fs/recovery.c
> index 6cc046d..f42e406 100644
> --- a/fs/f2fs/recovery.c
> +++ b/fs/f2fs/recovery.c
> @@ -173,10 +173,9 @@ out:
> static void destroy_fsync_dnodes(struct f2fs_sb_info *sbi,
> struct list_head *head)
> {
> - struct list_head *this;
> - struct fsync_inode_entry *entry;
> - list_for_each(this, head) {
> - entry = list_entry(this, struct fsync_inode_entry, list);
> + struct fsync_inode_entry *entry, *tmp;
> +
> + list_for_each_entry_safe(entry, tmp, head, list) {
> iput(entry->inode);
> list_del(&entry->list);
> kmem_cache_free(fsync_entry_slab, entry);

Thanks.

--
Dmitry


\
 
 \ /
  Last update: 2013-01-21 10:01    [W:0.832 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site