Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH 02/33] ARM: Convert to devm_ioremap_resource() | Date | Mon, 21 Jan 2013 17:23:07 +0000 |
| |
On Monday 21 January 2013, Russell King - ARM Linux wrote: > On Mon, Jan 21, 2013 at 05:05:47PM +0100, Thierry Reding wrote: > > On Mon, Jan 21, 2013 at 03:58:46PM +0000, Russell King - ARM Linux wrote: > > > On Mon, Jan 21, 2013 at 11:08:55AM +0100, Thierry Reding wrote: > > > > Convert all uses of devm_request_and_ioremap() to the newly introduced > > > > devm_ioremap_resource() which provides more consistent error handling. > > > > > > Does this include the resource part of the handling too? > > > > I'm not sure I understand your question. devm_ioremap_resource() does a > > devm_request_mem_region() internally if that's what you were asking. > > Ah, that's fine then. The function name is a little misleading, and as > it doesn't exist in mainline at present, it is not something I know about.
The usual problem with long patch series like this: The introductory mail PATCH 0/xx explains this nicely, but it's not possible to put everyone on Cc because then it gets rejected by vger for overly long mail headers.
We had a discussion about the function name earlier, but could not come up with one that isn't too bulky but still carries the same meaning as devm_request_and_ioremap() with a different symbol.
Arnd
| |