lkml.org 
[lkml]   [2013]   [Jan]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 17/33] misc: Convert to devm_ioremap_resource()
    Date
    Convert all uses of devm_request_and_ioremap() to the newly introduced
    devm_ioremap_resource() which provides more consistent error handling.

    devm_ioremap_resource() provides its own error messages so all explicit
    error messages can be removed from the failure code paths.

    Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
    Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Cc: Arnd Bergmann <arnd@arndb.de>
    ---
    drivers/misc/atmel-ssc.c | 8 +++-----
    1 file changed, 3 insertions(+), 5 deletions(-)

    diff --git a/drivers/misc/atmel-ssc.c b/drivers/misc/atmel-ssc.c
    index 3c09cbb..c208238 100644
    --- a/drivers/misc/atmel-ssc.c
    +++ b/drivers/misc/atmel-ssc.c
    @@ -159,11 +159,9 @@ static int ssc_probe(struct platform_device *pdev)
    return -ENXIO;
    }

    - ssc->regs = devm_request_and_ioremap(&pdev->dev, regs);
    - if (!ssc->regs) {
    - dev_dbg(&pdev->dev, "ioremap failed\n");
    - return -EINVAL;
    - }
    + ssc->regs = devm_ioremap_resource(&pdev->dev, regs);
    + if (IS_ERR(ssc->regs))
    + return PTR_ERR(ssc->regs);

    ssc->phybase = regs->start;

    --
    1.8.1.1


    \
     
     \ /
      Last update: 2013-01-21 12:43    [W:3.455 / U:1.400 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site