| Date | Mon, 21 Jan 2013 16:22:21 +0530 | Subject | Re: [PATCH 08/33] gpio: Convert to devm_ioremap_resource() | From | Viresh Kumar <> |
| |
On Mon, Jan 21, 2013 at 3:39 PM, Thierry Reding <thierry.reding@avionic-design.de> wrote: > diff --git a/drivers/gpio/gpio-spear-spics.c b/drivers/gpio/gpio-spear-spics.c > index 5f45fc4..7a4bf7c 100644 > --- a/drivers/gpio/gpio-spear-spics.c > +++ b/drivers/gpio/gpio-spear-spics.c > @@ -140,11 +140,9 @@ static int spics_gpio_probe(struct platform_device *pdev) > return -ENOMEM; > } > > - spics->base = devm_request_and_ioremap(&pdev->dev, res); > - if (!spics->base) { > - dev_err(&pdev->dev, "request and ioremap fail\n");
can we keep it as is?
> - return -ENOMEM; > - } > + spics->base = devm_ioremap_resource(&pdev->dev, res); > + if (IS_ERR(spics->base)) > + return PTR_ERR(spics->base); >
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
|