lkml.org 
[lkml]   [2013]   [Jan]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Staging: ramster: zcache-main: Fixed Bracing Issues
On Fri, Jan 18, 2013 at 11:09:56PM -0500, Jake Champlin wrote:
> Fixed Coding Style Bracing Issues
>
> Signed-off-by: Jake Champlin <jake.champlin.27@gmail.com>
> ---
> drivers/staging/ramster/zcache-main.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/ramster/zcache-main.c b/drivers/staging/ramster/zcache-main.c
> index a09dd5c..2613889 100644
> --- a/drivers/staging/ramster/zcache-main.c
> +++ b/drivers/staging/ramster/zcache-main.c
> @@ -478,6 +478,7 @@ static void zcache_free_page(struct page *page)
> #ifdef ZCACHE_DEBUG
> if (curr_pageframes > 2L || curr_pageframes < -2L) {
> /* pr_info here */
> + /* unnecessary comment */
> }
> #endif
> }

That doesn't look like it is fixing any coding style issues, you just
added a comment for no reason?

I understand it will shut checkpatch.pl up, but be reasonable here
please, it's a tool to be used as a guideline, use your judgement
please.

greg k-h


\
 
 \ /
  Last update: 2013-01-21 01:41    [W:0.036 / U:0.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site