Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [RFCv2 00/12] Introduce host-side virtio queue and CAIF Virtio. | Date | Thu, 17 Jan 2013 21:05:49 +1030 |
| |
Rusty Russell <rusty@rustcorp.com.au> writes: > "Michael S. Tsirkin" <mst@redhat.com> writes: >> On Wed, Jan 16, 2013 at 01:43:32PM +1030, Rusty Russell wrote: >>> "Michael S. Tsirkin" <mst@redhat.com> writes: >>> >> +static int resize_iovec(struct vringh_iov *iov, gfp_t gfp) >>> >> +{ >>> >> + struct iovec *new; >>> >> + unsigned int new_num = iov->max * 2; >>> > >>> > We must limit this I think, this is coming >>> > from userspace. How about UIO_MAXIOV? >>> >>> We limit it to the ring size already; >> >> 1. do we limit it in case there's a loop in the descriptor ring?
I didn't get a chance to do these revisions, as I spent today debugging the test framework. I won't get any more work on it until next week, so I've posted a rough series anyway for feedback (can also be found in my pending-rebases branch on kernel.org).
Thanks! Rusty.
| |