Messages in this thread Patch in this message | | | From | Mike Turquette <> | Subject | Re: [PATCH 1/2] clk: Add composite clock type | Date | Fri, 18 Jan 2013 13:09:28 -0800 |
| |
Quoting Prashant Gaikwad (2013-01-03 21:51:45) > Not all clocks are required to be decomposed into basic clock > types but at the same time want to use the functionality > provided by these basic clock types instead of duplicating. > > For example, Tegra SoC has ~100 clocks which can be decomposed > into Mux -> Div -> Gate clock types making the clock count to > ~300. Also, parent change operation can not be performed on gate > clock which forces to use mux clock in driver if want to change > the parent. > > Instead aggregate the basic clock types functionality into one > clock and just use this clock for all operations. This clock > type re-uses the functionality of basic clock types and not > limited to basic clock types but any hardware-specific > implementation. > > Signed-off-by: Prashant Gaikwad <pgaikwad@nvidia.com>
Hi Prashant,
I'm OK with the general concept of the composite clock, but a V2 patch addressing all of the comments needs to be submitted first. You might base your patch on top of the following cleanup:
From 135a829744067cb825b48f7422e22861e57d5ecd Mon Sep 17 00:00:00 2001 From: Mike Turquette <mturquette@linaro.org> Date: Fri, 18 Jan 2013 13:00:05 -0800 Subject: [PATCH] clk: beautify Makefile
The list of common clock types was getting a bit unmanageable. This patch puts only one file on each line and reorders the object files alphabetically. Also a newline is added to separate the sections.
Reported-by: Stephen Boyd <sboyd@codeaurora.org> Cc: Prashant Gaikwad <pgaikwad@nvidia.com> Signed-off-by: Mike Turquette <mturquette@linaro.org> --- drivers/clk/Makefile | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/clk/Makefile b/drivers/clk/Makefile index ee90e87..e73b1d6 100644 --- a/drivers/clk/Makefile +++ b/drivers/clk/Makefile @@ -1,8 +1,13 @@ # common clock types obj-$(CONFIG_HAVE_CLK) += clk-devres.o obj-$(CONFIG_CLKDEV_LOOKUP) += clkdev.o -obj-$(CONFIG_COMMON_CLK) += clk.o clk-fixed-rate.o clk-gate.o \ - clk-mux.o clk-divider.o clk-fixed-factor.o +obj-$(CONFIG_COMMON_CLK) += clk.o +obj-$(CONFIG_COMMON_CLK) += clk-divider.o +obj-$(CONFIG_COMMON_CLK) += clk-fixed-factor.o +obj-$(CONFIG_COMMON_CLK) += clk-fixed-rate.o +obj-$(CONFIG_COMMON_CLK) += clk-gate.o +obj-$(CONFIG_COMMON_CLK) += clk-mux.o + # SoCs specific obj-$(CONFIG_ARCH_BCM2835) += clk-bcm2835.o obj-$(CONFIG_ARCH_NOMADIK) += clk-nomadik.o -- 1.7.10.4
| |