Messages in this thread | | | Date | Fri, 18 Jan 2013 23:06:41 +0200 | From | Lasse Collin <> | Subject | Re: [PATCH 2/2] decompressors: make the default XZ_BCJ_* config match the selected architecture |
| |
On 2013-01-16 Florian Fainelli wrote: > On 01/15/2013 07:11 PM, Lasse Collin wrote: > > On 2013-01-15 Florian Fainelli wrote: > >> config XZ_DEC_X86 > >> bool "x86 BCJ filter decoder" if EXPERT > >> - default y > >> + default y if X86 > >> select XZ_DEC_BCJ > > [...] > > > > I think the "if EXPERT" strings should be dropped when all BCJ > > filters aren't enabled by default. One should be able to enable all > > filters without enabling EXPERT. > Ok, this would probably be a third patch, since my two patches > basically just modify what was already there, but I agree with you, > even though EXPERT is enabled by default on most architectures and > defconfigs. --
At least in x86_64_defconfig EXPERT isn't enabled. I'm fine with your patches once also the "if EXPERT" strings are removed.
Acked-by: Lasse Collin <lasse.collin@tukaani.org>
-- Lasse Collin | IRC: Larhzu @ IRCnet & Freenode
| |