Messages in this thread Patch in this message | | | Date | Fri, 18 Jan 2013 20:12:43 +0100 | From | Raoul Bhatia <> | Subject | [PATCH 3.2.y] drbd: add missing part round stats to drbd start io acct |
| |
commit 72585d2428fa3a0daab02ebad1f41e5ef517dbaa upstream
Please include upstream patch 72585d2428fa3a0daab02ebad1f41e5ef517dbaa into 3.2.y. Patch from git below.
Please also see the discussion at http://lists.linbit.com/pipermail/drbd-user/2012-January/017622.html
and the upstream patches at https://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=commitdiff;h=72585d2428fa3a0daab02ebad1f41e5ef517dbaa http://git.drbd.org/gitweb.cgi?p=drbd-8.3.git;a=commitdiff;h=80cb2183911626747d3f7546fe3cb3c1abe6ba41
Thanks, Raoul
From 72585d2428fa3a0daab02ebad1f41e5ef517dbaa Mon Sep 17 00:00:00 2001 From: Philipp Reisner <philipp.reisner@linbit.com> Date: Thu, 23 Feb 2012 12:56:26 +0100 Subject: [PATCH] drbd: add missing part_round_stats to _drbd_start_io_acct
Without this, iostat frequently sees bogus svctime and >= 100% "utilization".
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com> Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com> --- drivers/block/drbd/drbd_req.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/block/drbd/drbd_req.c b/drivers/block/drbd/drbd_req.c index 4737ad1..bfd14bc 100644 --- a/drivers/block/drbd/drbd_req.c +++ b/drivers/block/drbd/drbd_req.c @@ -39,6 +39,7 @@ static void _drbd_start_io_acct(struct drbd_conf *mdev, struct drbd_request *req const int rw = bio_data_dir(bio); int cpu; cpu = part_stat_lock(); + part_round_stats(cpu, &mdev->vdisk->part0); part_stat_inc(cpu, &mdev->vdisk->part0, ios[rw]); part_stat_add(cpu, &mdev->vdisk->part0, sectors[rw], bio_sectors(bio)); (void) cpu; /* The macro invocations above want the cpu argument, I do not like -- 1.7.6.5 -- DI (FH) Raoul Bhatia M.Sc. | E-Mail. raoul@bhatia.at Software Development and | Web. http://www.ipax.at System Administration | Tel. +43 699 10132530
| |