lkml.org 
[lkml]   [2013]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/2] perf tools: add evsel prev_raw_count field
On Fri, Jan 18, 2013 at 02:06:27PM +0100, Stephane Eranian wrote:
> This field will be used by commands which print
> counter deltas on regular timer intervals,
> such as perf stat -I.
>
> Signed-off-by: Stephane Eranian <eranian@google.com>
> ---
> tools/perf/util/evsel.c | 21 +++++++++++++++++++++
> tools/perf/util/evsel.h | 1 +
> 2 files changed, 22 insertions(+)
>
> diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
> index 1b16dd1..132da7c 100644
> --- a/tools/perf/util/evsel.c
> +++ b/tools/perf/util/evsel.c
> @@ -646,6 +646,17 @@ int __perf_evsel__read_on_cpu(struct perf_evsel *evsel,
> if (readn(FD(evsel, cpu, thread), &count, nv * sizeof(u64)) < 0)
> return -errno;
>
> + if (evsel->prev_raw_counts) {
> + struct perf_counts_values tmp;
> +
> + tmp = evsel->prev_raw_counts->cpu[cpu];
> + evsel->prev_raw_counts->cpu[cpu] = count;
> +
> + count.val = count.val - tmp.val;
> + count.ena = count.ena - tmp.ena;
> + count.run = count.run - tmp.run;
> + }
> +
> if (scale) {
> if (count.run == 0)
> count.val = 0;
> @@ -684,6 +695,16 @@ int __perf_evsel__read(struct perf_evsel *evsel,
> }
> }
>
> + if (evsel->prev_raw_counts) {
> + struct perf_counts_values tmp = evsel->prev_raw_counts->aggr;
> +
> + evsel->prev_raw_counts->aggr = *aggr;
> +
> + aggr->val = aggr->val - tmp.val;
> + aggr->ena = aggr->ena - tmp.ena;
> + aggr->run = aggr->run - tmp.run;
> + }

this and the hunk above looks like candidates for function

jirka


\
 
 \ /
  Last update: 2013-01-18 15:21    [W:0.046 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site