lkml.org 
[lkml]   [2013]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 125/222] mtd: nand: gpmi: reset BCH earlier, too, to avoid NAND startup problems
    Date
    3.5.7.3 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Wolfram Sang <w.sang@pengutronix.de>

    commit 6f2a6a52560ad8d85710aabd92b7a3239b3a6b07 upstream.

    It could happen (1 out of 100 times) that NAND did not start up
    correctly after warm rebooting, so the kernel could not find the UBI or
    DMA timed out due to a stalled BCH. When resetting BCH together with
    GPMI, the issue could not be observed anymore (after 10000+ reboots). We
    probably need the consistent state already before sending any command to
    NAND, even when no ECC is needed. I chose to keep the extra reset for
    BCH when changing the flash layout to be on the safe side.

    Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
    Acked-by: Huang Shijie <b32955@freescale.com>
    Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
    Signed-off-by: Herton Ronaldo Krzesinski <herton.krzesinski@canonical.com>
    ---
    drivers/mtd/nand/gpmi-nand/gpmi-lib.c | 9 +++++++++
    1 file changed, 9 insertions(+)

    diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-lib.c b/drivers/mtd/nand/gpmi-nand/gpmi-lib.c
    index a1f4332..b27e215 100644
    --- a/drivers/mtd/nand/gpmi-nand/gpmi-lib.c
    +++ b/drivers/mtd/nand/gpmi-nand/gpmi-lib.c
    @@ -136,6 +136,15 @@ int gpmi_init(struct gpmi_nand_data *this)
    if (ret)
    goto err_out;

    + /*
    + * Reset BCH here, too. We got failures otherwise :(
    + * See later BCH reset for explanation of MX23 handling
    + */
    + ret = gpmi_reset_block(r->bch_regs, GPMI_IS_MX23(this));
    + if (ret)
    + goto err_out;
    +
    +
    /* Choose NAND mode. */
    writel(BM_GPMI_CTRL1_GPMI_MODE, r->gpmi_regs + HW_GPMI_CTRL1_CLR);

    --
    1.7.9.5


    \
     
     \ /
      Last update: 2013-01-16 18:44    [W:4.066 / U:0.096 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site