lkml.org 
[lkml]   [2013]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 07/13] perf hist browser: Add support for event group view
Date
On Tue, 15 Jan 2013 15:32:26 -0300, Arnaldo Carvalho de Melo wrote:
> Em Tue, Jan 15, 2013 at 04:31:51PM +0900, Namhyung Kim escreveu:
>> From: Namhyung Kim <namhyung.kim@lge.com>
>>
>> Show group members' overhead also when showing the leader's if event
>> group is enabled. Use macro for defining hpp functions which looks
>> almost identical.
>>
>> Also move coloring logic into the hpp function so that each value can
>> be colored independently.
>
> Just from reading the description: when we have this "Also do this extra
> thing" it smells like we need to break the patch in two... Can this be
> done?

Sure. I'll break it.

Thanks,
Namhyung


\
 
 \ /
  Last update: 2013-01-16 11:21    [W:0.057 / U:0.252 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site