lkml.org 
[lkml]   [2013]   [Jan]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[ 085/171] staging: speakup: avoid out-of-range access in synth_add()
    Date
    3.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Samuel Thibault <samuel.thibault@ens-lyon.org>

    commit 6102c48bd421074a33e102f2ebda3724e8d275f9 upstream.

    Check that array index is in-bounds before accessing the synths[] array.

    Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
    Cc: Nickolai Zeldovich <nickolai@csail.mit.edu>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/staging/speakup/synth.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/staging/speakup/synth.c
    +++ b/drivers/staging/speakup/synth.c
    @@ -423,7 +423,7 @@ int synth_add(struct spk_synth *in_synth
    int i;
    int status = 0;
    mutex_lock(&spk_mutex);
    - for (i = 0; synths[i] != NULL && i < MAXSYNTHS; i++)
    + for (i = 0; i < MAXSYNTHS && synths[i] != NULL; i++)
    /* synth_remove() is responsible for rotating the array down */
    if (in_synth == synths[i]) {
    mutex_unlock(&spk_mutex);



    \
     
     \ /
      Last update: 2013-01-16 01:41    [W:4.242 / U:0.196 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site