lkml.org 
[lkml]   [2013]   [Jan]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[ 191/221] libceph: report connection fault with warning
    Date
    3.7-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Alex Elder <elder@inktank.com>

    (cherry picked from commit 28362986f8743124b3a0fda20a8ed3e80309cce1)

    When a connection's socket disconnects, or if there's a protocol
    error of some kind on the connection, a fault is signaled and
    the connection is reset (closed and reopened, basically). We
    currently get an error message on the log whenever this occurs.

    A ceph connection will attempt to reestablish a socket connection
    repeatedly if a fault occurs. This means that these error messages
    will get repeatedly added to the log, which is undesirable.

    Change the error message to be a warning, so they don't get
    logged by default.

    Signed-off-by: Alex Elder <elder@inktank.com>
    Reviewed-by: Sage Weil <sage@inktank.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    net/ceph/messenger.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/net/ceph/messenger.c
    +++ b/net/ceph/messenger.c
    @@ -2369,7 +2369,7 @@ fault:
    static void ceph_fault(struct ceph_connection *con)
    __releases(con->mutex)
    {
    - pr_err("%s%lld %s %s\n", ENTITY_NAME(con->peer_name),
    + pr_warning("%s%lld %s %s\n", ENTITY_NAME(con->peer_name),
    ceph_pr_addr(&con->peer_addr.in_addr), con->error_msg);
    dout("fault %p state %lu to peer %s\n",
    con, con->state, ceph_pr_addr(&con->peer_addr.in_addr));



    \
     
     \ /
      Last update: 2013-01-16 01:21    [W:4.063 / U:0.116 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site