lkml.org 
[lkml]   [2013]   [Jan]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v8 08/22] PCI, acpiphp: Separate out hot-add support of pci host bridge
    From
    On Mon, Jan 14, 2013 at 10:44 PM, Yinghai Lu <yinghai@kernel.org> wrote:
    > On Sat, Jan 12, 2013 at 3:18 PM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
    >>> @@ -673,3 +673,223 @@ int __init acpi_pci_root_init(void)
    >>>
    >>> return 0;
    >>> }
    >>> +
    >>> +/*
    >>> + * Separated from drivers/pci/hotplug/acpiphp_glue.c
    >>> + * only support root bridge
    >>> + */
    >>
    >> This comment will be useless after applying the patch.
    >>
    >>> +
    >>> +static LIST_HEAD(acpi_root_bridge_list);
    >>> +struct acpi_root_bridge {
    >>> + struct list_head list;
    >>> + acpi_handle handle;
    >>> + u32 flags;
    >>> +};
    >>
    >> We have struct acpi_pci_root already. Why do we need this in addition?
    >
    > will address that in following patch.

    please check if you are ok with merging attached 5 patches in to one
    patches instead.

    Thanks

    Yinghai
    [unhandled content-type:application/octet-stream][unhandled content-type:application/octet-stream][unhandled content-type:application/octet-stream][unhandled content-type:application/octet-stream]
    \
     
     \ /
      Last update: 2013-01-15 20:23    [W:2.735 / U:0.484 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site