Messages in this thread | | | Date | Tue, 15 Jan 2013 17:48:43 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH v7u1 22/31] x86, boot: add fields to support load bzImage and ramdisk above 4G |
| |
On Tue, Jan 15, 2013 at 08:03:49AM -0800, Yinghai Lu wrote: > Come on, are you serious? almost none?
Of course I'm serious - the fact that I'm diddling with your patchset for weeks now should tell you I'm f*cking serious about this.
> I took the comments about sentinel. > but did not take your comments about change kernel_ident_mapping_init.
Because... ? I saw that you didn't take it but why, you didn't even say why you didn't take it. And I asked you at the beginning: should we review this patchset or do you simply ignore comments.
Let's see:
* [PATCH 06/31] x86, 64bit, realmode: use init_level4_pgt to set trapmoline_pgt directly - typo still there
* [PATCH 08/31] x86, 64bit: early #PF handler set page table - almost no changes, SOB chain still wrong
* [PATCH 12/31] x86: add get_ramdisk_image/size() - no change
* [PATCH 13/31] x86, boot: add get_cmd_line_ptr() - no change
* [PATCH 14/31] x86, boot: move checking of cmd_line_ptr out of common path - no change
* [PATCH 20/31] x86, kexec: replace ident_mapping_init and init_level4_page - no change
* [PATCH 21/31] x86, kexec: only set ident mapping for ram. - almost
* [PATCH 22/31] x86, boot: add fields to support load bzImage and ramdisk above 4G - except sentinel, almost no change
* [PATCH 23/31] x86, boot: update comments about entries for 64bit image - almost no change
How's that for "almost none"?!
Oh, and also, some of the suggestions you've taken but then changed again making them wrong. Here's an example:
Your initial change had:
> +The memory for struct boot_params should be allocated under or above > +4G and initialized to all zero.
I suggested:
"Memory for struct boot_params may be allocated anywhere (even above 4G). This memory must be zeroed out."
You changed it to:
"The memory for struct boot_params could be allocated anywhere (even above 4G) and initialized to all zero."
which still reads funny and has a couple of issues.
-- Regards/Gruss, Boris.
Sent from a fat crate under my desk. Formatting is fine. --
| |