lkml.org 
[lkml]   [2013]   [Jan]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] tools lib traceevent: Fix warning on '>=' operator
From
Date
On Tue, 2013-01-15 at 17:02 +0900, Namhyung Kim wrote:
> From: Namhyung Kim <namhyung.kim@lge.com>
>
> Although the '>=' (and '<=') operator is handled properly in
> libtraceevent, it emitted following spurious warnings on perf test:
>
> $ perf test
> 5: parse events tests :
> ...
> Warning: unknown op '>='
> Warning: unknown op '>='
> Warning: unknown op '>='
> Warning: unknown op '>='
> Warning: unknown op '>='
> Warning: unknown op '>='
> ...
>
> Add the operator to the checks.
>

Acked-by: Steven Rostedt <rostedt@goodmis.org>

-- Steve

> Cc: Frederic Weisbecker <fweisbec@gmail.com>
> Cc: Jiri Olsa <jolsa@redhat.com>
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> ---
> tools/lib/traceevent/event-parse.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c
> index 5a824e355d04..7286f0e82c29 100644
> --- a/tools/lib/traceevent/event-parse.c
> +++ b/tools/lib/traceevent/event-parse.c
> @@ -1785,6 +1785,8 @@ process_op(struct event_format *event, struct print_arg *arg, char **tok)
> strcmp(token, "/") == 0 ||
> strcmp(token, "<") == 0 ||
> strcmp(token, ">") == 0 ||
> + strcmp(token, "<=") == 0 ||
> + strcmp(token, ">=") == 0 ||
> strcmp(token, "==") == 0 ||
> strcmp(token, "!=") == 0) {
>




\
 
 \ /
  Last update: 2013-01-15 16:43    [W:0.040 / U:2.548 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site