lkml.org 
[lkml]   [2013]   [Jan]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] module, async: async_synchronize_full() on module init iff async is used
    Hello, Linus.

    On Tue, Jan 15, 2013 at 07:00:31PM -0800, Linus Torvalds wrote:
    > That said, maybe we could just make the rule be that you can't pick a
    > default IO scheduler that is modular.

    This is definitely much more preferable but it would affect use case
    where everything is built modular and the elevator is selected via
    kernel param. This is way outside the usual usage and we can warn
    about the new behavior but it still is an observable behavior change.
    Do you think this would be okay?

    > And I *would* like to see the warning we discussed. Maybe there are
    > other situations that can trigger this?
    >
    > Because something like that
    >
    > WARN_ON_ONCE(wait && i_am_async() && system_state == SYSTEM_RUNNING);
    >
    > in kernel/kmod.c (__request_module()) still sounds like a good idea to
    > verify that this is the only thing that triggers it (of course, we'd
    > need to somehow avoid the warning for the known case with the known
    > workaround).

    And then this warning can be added without introducing
    request_module_but_dont_warn_about_being_called_from_async().

    Thanks.

    --
    tejun


    \
     
     \ /
      Last update: 2013-01-16 05:01    [W:4.215 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site