Messages in this thread | | | Subject | Re: [ 19/49] NFSv4: Add ACCESS operation to OPEN compound | From | Ben Hutchings <> | Date | Wed, 16 Jan 2013 01:08:57 +0000 |
| |
On Tue, 2013-01-15 at 16:42 -0200, Herton Ronaldo Krzesinski wrote: > On Sun, Jan 13, 2013 at 05:43:14PM +0000, Ben Hutchings wrote: > > 3.2-stable review patch. If anyone has any objections, please let me know. > > > > ------------------ > > > > From: Weston Andros Adamson <dros@netapp.com> > > > > commit 6168f62cbde8dcf4f58255794efbcdb8df603959 upstream. > > > > The OPEN operation has no way to differentiate an open for read and an > > open for execution - both look like read to the server. This allowed > > users to read files that didn't have READ access but did have EXEC access, > > which is obviously wrong. > > > > This patch adds an ACCESS call to the OPEN compound to handle the > > difference between OPENs for reading and execution. Since we're going > > through the trouble of calling ACCESS, we check all possible access bits > > and cache the results hopefully avoiding an ACCESS call in the future. > > > > Signed-off-by: Weston Andros Adamson <dros@netapp.com> > > Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com> > > [bwh: Backported to 3.2: > > - Adjust context > > - #include <linux/export.h> in fs/nfs/dir.c] > > Signed-off-by: Ben Hutchings <ben@decadent.org.uk> > > This 3.2 series lacks commit ae2bb03236fc978bdf673c19d39832500793b83c > pointed in its changelog as fixing a regression from this one.
Thanks. Actually I'm not at all confident about the adjustments to these NFSv4 access changes, so I'll drop them all for now.
Ben.
-- Ben Hutchings Quantity is no substitute for quality, but it's the only one we've got. [unhandled content-type:application/pgp-signature] | |