lkml.org 
[lkml]   [2013]   [Jan]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v3 43/44] tty/metag_da: Add metag DA TTY driver
    Hi,

    On 01/11/2013 11:50 AM, James Hogan wrote:
    >>> + channel_driver->driver_name = "ttyDA";
    >>
    >> This should be rather "metag".
    >
    > Yes, I'll set to "metag_da" if that's okay since the transport is
    > the DA. I presume this is pretty much just to appear in
    > /proc/tty/drivers?

    Yes.

    >>> +static void dashtty_exit(void) +{ +
    >>> del_timer_sync(&put_timer); + kthread_stop(dashtty_thread); +
    >>> del_timer_sync(&poll_timer); +
    >>> tty_unregister_driver(channel_driver); +
    >>> put_tty_driver(channel_driver);
    >>
    >> No tty_port_destroy anywhere?
    >
    > Ah yes, I've added a loop to do this before put_tty_driver() both
    > here and in the error handling of dashtty_init().
    >
    > This driver isn't actually buildable as a module at the moment, but
    > if it was, would the module owner being set ensure that the
    > ttys/ports are closed down prior to dashtty_exit being called?
    > (i.e. is it racy?)

    Yeah, dashtty_exit won't be called until all openers are gone.

    regards,
    --
    js
    suse labs


    \
     
     \ /
      Last update: 2013-01-14 12:01    [W:7.354 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site