Messages in this thread | | | From | "Kim, Milo" <> | Subject | RE: [PATCH 2/3] regulator-core: update all enable GPIO state in _enable/disable | Date | Sun, 13 Jan 2013 23:35:03 +0000 |
| |
> From: Mark Brown [mailto:broonie@opensource.wolfsonmicro.com] > > This isn't quite going to work properly - we need to actually move the > state (and also a reference count) into some sort of shared state. > Otherwise consider what happens in this scenario: > > 1. regulator 1 enables > 2. regulator 2 enables > 3. regulator 1 disables > > Since regulator 1 doesn't know anything about regulator 2 it'll not > know > that regulator 2 should still be enabled so it'll put the GPIO into the > disabled state. It'll be OK if regulator 1 and regulator 2 always have > the same state but if they ever differ then we'll not do the right > thing.
Thanks for your opinion. My understanding is 'shared' enable pin means regulators are enabled/disabled at the same time. Any other case is possible?
Best Regards, Milo
| |