[lkml]   [2013]   [Jan]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH RFT 3/3] ARM: tegra: dts: seaboard: enable keyboard
On Sat, Jan 12, 2013 at 04:04:28PM +0530, Laxman Dewangan wrote:
> Going through clock driver, the clk_get() should return error pointer or
> valid pointer, atleast not NULL.

No. clk_get() will return whatever value the 'clk' pointer found in
the clk_lookup structure contains. Or it will return an error pointer.

This topic has had enough discussion in the past that I'll say: go and
look up in the archives emails from me on this subject. I've been very
clear over the years about this.

> Probably our clock driver is returning to NULL and hence issue is
> becasue whole world, it check for IS_ERR or !IS_ERR() and null clk
> pointer treated as !IS_ERR().

Probably not. As far as _drivers_ go, either the clk cookie is an error
(IS_ERR() is true) _OR_ it is valid to be passed back into the clock API.
You will find statements from me in the past to that: whatever clk_get()
returns which is _not_ an error must be accepted by the rest of the clk

Drivers never dereference the returned clk, so why should they care about
anything other than "is it an error" given by IS_ERR(). (notice the lack
of question mark, that's not a question to be answered.)

 \ /
  Last update: 2013-01-12 12:41    [W:0.050 / U:4.456 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site