lkml.org 
[lkml]   [2013]   [Jan]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [RFC][PATCH 0/2] staging: alarm-dev: compat_ioctl support
From
On Fri, Jan 11, 2013 at 1:48 PM, John Stultz <john.stultz@linaro.org> wrote:
> This is a first-pass at implementing compat_ioctl support for
> Android's alarm-dev driver in staging.
>
> The first patch is some refactoring to cleanup and separate the
> copying of user data from the logic, and the second patch adds
> the compat_ioctl support.
>
> As noted in the patch, the only really squirly bit is the handling
> of ANDROID_ALARM_SET_OLD and ANDROID_ALARM_SET_AND_WAIT_OLD. These
> are present to support existing older Android applications.
> Unfortunately these cause ioctl number aliasing issues with
> the compat ioctls, so on 64bit they are only supported in the
> compat patch (since any existing android app old enough to use
> them are likely 32bit).
>
> I'd appreciate feedback from the Android devs on if this is
> an ok assumption and if it might be reasonable to establish
> some sort of a phase-out timeline for the _OLD ioctl support.

The "support old userspace code" comment for those two ioctls has been
there since pre-Android 1.0. Those apis are not exposed to Android
apps, I don't see any problem deleting them.


\
 
 \ /
  Last update: 2013-01-11 23:41    [W:0.032 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site