lkml.org 
[lkml]   [2013]   [Jan]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[RFC][PATCH 0/2] staging: alarm-dev: compat_ioctl support
Date
This is a first-pass at implementing compat_ioctl support for
Android's alarm-dev driver in staging.

The first patch is some refactoring to cleanup and separate the
copying of user data from the logic, and the second patch adds
the compat_ioctl support.

As noted in the patch, the only really squirly bit is the handling
of ANDROID_ALARM_SET_OLD and ANDROID_ALARM_SET_AND_WAIT_OLD. These
are present to support existing older Android applications.
Unfortunately these cause ioctl number aliasing issues with
the compat ioctls, so on 64bit they are only supported in the
compat patch (since any existing android app old enough to use
them are likely 32bit).

I'd appreciate feedback from the Android devs on if this is
an ok assumption and if it might be reasonable to establish
some sort of a phase-out timeline for the _OLD ioctl support.

Any other feedback or thoughts would be welcome!

thanks
-john

Cc: Greg KH <gregkh@linuxfoundation.org>
Cc: Serban Constantinescu <serban.constantinescu@arm.com>
Cc: Arve Hjønnevåg <arve@android.com>
Cc: Android Kernel Team <kernel-team@android.com>

John Stultz (2):
staging: alarm-dev: Refactor alarm-dev ioctl code in prep for
compat_ioctl
staging: alarm-dev: Implement compat_ioctl support

drivers/staging/android/alarm-dev.c | 290 +++++++++++++++++++++----------
drivers/staging/android/android_alarm.h | 19 ++
2 files changed, 213 insertions(+), 96 deletions(-)

--
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2013-01-11 23:41    [W:0.045 / U:1.380 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site